Move from bounds on low-level objects to BP Send bounds#3776
Merged
jkczyz merged 1 commit intolightningdevkit:mainfrom May 14, 2025
Merged
Move from bounds on low-level objects to BP Send bounds#3776jkczyz merged 1 commit intolightningdevkit:mainfrom
Send bounds#3776jkczyz merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @jkczyz as a reviewer! |
joostjager
previously approved these changes
May 13, 2025
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
Starting to understand how it works now.
Rather than bounding the traits used in `OutputSweeper`, move the bounds to where we actually require them - a top-level `Send` bound on the `Deref`-to-`OutputSweeper` type itself.
TheBlueMatt
force-pushed
the
2025-05-higher-level-bounds
branch
from
adf4614 to
61cd37d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3776 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 157 157
Lines 125450 125450
Branches 125450 125450
=======================================
Hits 112305 112305
+ Misses 10445 10442 -3
- Partials 2700 2703 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Rebased after dependent PR got merged. |
joostjager
approved these changes
May 14, 2025
jkczyz
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3734